Skip to content

Conversation

@Umair-exe
Copy link

Description

Visual changes

Functional changes

  • Code style has been fixed by running the composer cs command.
  • Changes have been tested to not break existing functionality.
  • Documentation is up-to-date.

…ivewire components

Update QueryBuilder implementation to properly handle constraints
Copy link
Member

@People-Sea People-Sea left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. This defensive fix addresses the issue.

The root cause is a state/schema cache synchronization issue, but this null check is a reasonable and low-risk solution.

@danharrin
Copy link
Member

I would like to understand the cause of the error before choosing to silence it like this, I'm confused why the synchronisation issue is there based on the issue description

@People-Sea
Copy link
Member

People-Sea commented Jan 28, 2026

I would like to understand the cause of the error before choosing to silence it like this, I'm confused why the synchronisation issue is there based on the issue description

@danharrin From my debugging, it seems related to statePath switching in applyFiltersToTableQuery() causing cachedDefaultChildSchemas to be built from the wrong statePath.

@Umair-exe
Copy link
Author

When getChildSchema($ruleIndex) is called with a non-default key (the rule index), and if there are no components registered for that key, the method returns null instead of returning an empty schema.

This happens in the Builder component when iterating through rules. The $ruleBuilder->getChildSchema($ruleIndex) call expects to get a child schema for each item/rule, but when the $ruleIndex doesn't have cached child schemas yet, it returns null.

@danharrin
Copy link
Member

I think #19128 addresses the root issue instead of silencing it

I would appreciate @Umair-exe to check if it still solves their problem and @People-Sea to review if the code is sane or not - thanks for your comment about the child schema caching, that made it easy to trace the problem

@danharrin danharrin closed this Jan 29, 2026
@github-project-automation github-project-automation bot moved this from Todo to Done in Roadmap Jan 29, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

v4 Filament Tables Query Builder Filters Not Applying Constraints Correctly in Standalone Livewire Components

3 participants