fix: use get$WireUsing to retrieve wire instance in getFileAttachmentUrl #19007
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
Can you rebase this on 4.x instead of 5.x please? |
Member
Author
OK, I will start a new pull request from version 4.x. |
Member
|
You shouldn't need to start a new PR, just rebase the branch |
People-Sea
force-pushed
the
fix/form/rich-editr-local-files
branch
from
12bb05b to
73864d8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fix: prevent ReferenceError when $wire is not defined by using get$WireUsing().__instance in packages/forms/resources/js/components/rich-editor/extension-local-files.js
Visual changes
before
before.mov
after
after.mov
Functional changes
composer cscommand.