[4.x[ chore(git): add .gitignore and .gitattributes for subtree packages #19005
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Introduce `.gitignore` and `.gitattributes` files for various subtree packages to manage ignored files and streamline exports during subtree splitting.
danharrin
requested changes
Jan 20, 2026
Member
danharrin
left a comment
danharrin
left a comment
There was a problem hiding this comment.
Thanks, but I think most of these changes do not do anything in practice. Please remove all the new .gitignore files as none of the paths mentioned exist in each package, and are caught by the monorepo .gitignore. I think the only thing we should keep is the /.github export-ignore line in .gitattributes for each package, the rest can be removed.
Member
|
Also its worth rebasing this on 4.x instead of 5.x |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introduce
.gitignoreand.gitattributesfiles for various subtree packages to manage ignored files and streamline exports during subtree splitting.