Fallback to existing mention label if provider does not return a label #19000
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
Can you please rebase this on 4.x? |
gehrisandro
force-pushed
the
feat/fallback-to-original-mention-label
branch
from
29df16c to
20820c1
Compare
Contributor
Author
Done |
danharrin
approved these changes
Jan 21, 2026
Member
|
@gehrisandro I removed a block that you modified because I don't think we need to remove the label from the mention in any case now |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR changes the mention rendering to fallback to the stored label in the database according to the discussion here: #18984
In addition the label gets persisted to the database even if a
MentionProvideris available (otherwise there is nothing to fall back to).Visual changes
Before (when user is not available anymore):
After:
When the provider returns a label (in my case, the user still exists), there is no visual change.
Functional changes
composer cscommand.Documentation is up-to-date.(no change required)