Skip to content

Conversation

@mmartinv
Copy link
Collaborator

Remove the go-vendor-tools.conf from spec and packit conf
as it's not used.

Signed-off-by: Miguel Martín [email protected]

@gemini-code-assist
Copy link

Summary of Changes

Hello @mmartinv, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request focuses on cleaning up the project's build and packaging configurations by removing references to an obsolete file, go-vendor-tools.toml. This ensures that both the .packit.yaml and the RPM spec file (go-fdo-server.spec) are streamlined and accurately reflect the current state of the project's dependencies and build process, eliminating unnecessary file syncing and outdated source declarations.

Highlights

  • Configuration Cleanup: The go-vendor-tools.toml file, which is no longer in use, has been removed from the .packit.yaml configuration to prevent it from being synced unnecessarily.
  • RPM Spec File Update: The go-fdo-server.spec file has been updated to remove the Source directive referencing go-vendor-tools.toml and re-index the subsequent Source directives and their usage in install and %sysusers_create_compat commands.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request removes the unused go-vendor-tools.toml file from the packit configuration and the RPM spec file. The changes are straightforward and correct, including the re-numbering of sources in the spec file. I have one suggestion to improve the clarity of a comment in go-fdo-server.spec for better long-term maintainability.

@mmartinv mmartinv force-pushed the remove-go-vendor-tools-from-spec branch from 35b8c31 to c72313e Compare November 26, 2025 09:57
Remove the go-vendor-tools.conf from spec and packit conf
as it's not used.

Signed-off-by: Miguel Martín <[email protected]>
@mmartinv mmartinv force-pushed the remove-go-vendor-tools-from-spec branch from c72313e to 4f7f8a9 Compare November 28, 2025 15:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants