Skip to content

Conversation

@mmartinv
Copy link
Collaborator

Signed-off-by: Miguel Martín [email protected]

@gemini-code-assist
Copy link

Summary of Changes

Hello @mmartinv, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request refactors the packit integration for the go-fdo-client project by centralizing the logic for generating vendor tarballs and license reports into a new Makefile target. This change streamlines the build process, ensures the vendor tarball is created earlier in the packit workflow, and improves the overall maintainability of the build configuration.

Highlights

  • Packit Workflow Refinement: The packit configuration has been updated to move the vendor tarball generation logic from inline bash scripts to a dedicated Makefile target.
  • Early Vendor Tarball Generation: The vendor tarball is now generated during the pre-sync stage of the packit workflow, ensuring it's available earlier.
  • Centralized Build Logic: A new packit-vendor-tarball target in the Makefile centralizes the go_vendor_archive and go_vendor_license commands, improving maintainability.
  • Enhanced Versioning: The Makefile's VERSION variable now incorporates the short commit hash, providing more detailed version information for builds.
  • Local SRPM Build Target: A new srpm target has been added to the Makefile to facilitate local SRPM generation.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

@mmartinv mmartinv requested review from kgiusti and runcom November 25, 2025 14:41
Copy link

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request refactors the packit configuration by moving the vendor tarball generation logic into the Makefile. This is a good simplification of the .packit.yaml file. However, I've found a critical issue in the new Makefile target that will cause the build to fail or produce incorrect artifacts. I've also included a couple of suggestions to improve maintainability in both the Makefile and the packit configuration.

@mmartinv mmartinv force-pushed the fix-packit-configuration branch from d2993eb to 31046a7 Compare November 25, 2025 16:12
@mmartinv mmartinv force-pushed the fix-packit-configuration branch from 31046a7 to 5db1027 Compare November 26, 2025 14:19
@mmartinv mmartinv changed the title fix(packit): generate vendor tarball also in pre-sync fix(packit): remove unused section and files Nov 26, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants