Skip to content

Conversation

@mmartinv
Copy link
Collaborator

@mmartinv mmartinv commented Nov 12, 2025

Build the go-fdo-client RPMs in the same way as go-fdo-server ones

kgiusti
kgiusti previously approved these changes Nov 12, 2025
Copy link
Collaborator

@kgiusti kgiusti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice improvement!

Copy link
Member

@runcom runcom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm (but probably pending the go-fdo bump + use of go1.25)

@mmartinv mmartinv force-pushed the server-rpm-builds-parity branch 4 times, most recently from f45eca6 to 9f63fe3 Compare November 12, 2025 15:59
@runcom
Copy link
Member

runcom commented Nov 12, 2025

if you've rebased, the to0 call is now gone and tests need to be adapted unfortunately

 > GET /api/v1/to0/ea47cf1af24a1dfa8de77e599d25b175 HTTP/1.1
> Host: owner:8043
> User-Agent: curl/8.5.0
> Accept: */*
> 
< HTTP/1.1 404 Not Found
< Content-Type: text/plain; charset=utf-8
< X-Content-Type-Options: nosniff
< Date: Wed, 12 Nov 2025 16:01:27 GMT
< Content-Length: 19
* The requested URL returned error: 404
* Closing connection
[{"dns":"172.18.0.2","port":"8043","protocol":"http","ip":"172.18.0.2"}]

@mmartinv mmartinv force-pushed the server-rpm-builds-parity branch 9 times, most recently from 7304be0 to bfcbddf Compare November 13, 2025 14:21
@mmartinv mmartinv force-pushed the server-rpm-builds-parity branch 4 times, most recently from ffd9cb9 to aa560b0 Compare November 13, 2025 17:18
@packit-as-a-service
Copy link

Failed to load packit config file:

Cannot parse package config. ValidationError({'jobs': {2: {'packages': defaultdict(<class 'dict'>, {'go-fdo-client-fedora': {'value': {'rawhide': ['Unknown field.']}}})}}})

For more info, please check out the documentation or contact the Packit team. You can also use our CLI command config validate or our pre-commit hooks for validation of the configuration.

@mmartinv mmartinv force-pushed the server-rpm-builds-parity branch 6 times, most recently from 34df1ef to 71aa948 Compare November 14, 2025 11:35
@mmartinv mmartinv force-pushed the server-rpm-builds-parity branch from 0a8c4f4 to 9f61c4d Compare November 19, 2025 16:22
@mmartinv mmartinv requested a review from runcom November 19, 2025 16:31
@runcom
Copy link
Member

runcom commented Nov 19, 2025

tests still failing with

Nov 19 16:30:46 ip-172-31-18-144.us-east-2.compute.internal sh[3983]: Error: open /etc/go-fdo-server/owner.key: permission denied

@mmartinv mmartinv force-pushed the server-rpm-builds-parity branch 9 times, most recently from b44a936 to fed6666 Compare November 21, 2025 10:48
runcom
runcom previously approved these changes Nov 21, 2025
export GO_VENDOR_TOOLS_CONFIG=${BASE_DIR}/go-vendor-tools.toml
export SPEC_FILE=${BASE_DIR}/go-fdo-client.spec
# Download the source tarball (Source0) needed by go_vendor_archive
spectool -g -C ${BASE_DIR} ${SPEC_FILE} || exit 1
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The spec file used here doesn't have commit/version/release modified (it seems it's using the hardcoded commit value) see https://dashboard.packit.dev/jobs/propose-downstream/22467

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, it looks like fix-spec-file does not apply to propose-downstream action, we need to modify the commit hash in the post-upstream-clone or pre-sync hooks. See: https://packit.dev/docs/configuration/actions

@mmartinv mmartinv force-pushed the server-rpm-builds-parity branch 4 times, most recently from 004edb2 to 0ebada2 Compare November 24, 2025 10:52
@mmartinv mmartinv force-pushed the server-rpm-builds-parity branch from 0ebada2 to adb264b Compare November 24, 2025 11:06
@runcom runcom merged commit cee7b29 into fido-device-onboard:main Nov 24, 2025
24 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants