-
Notifications
You must be signed in to change notification settings - Fork 11
chore: align with go-fdo-server rpm builds #41
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: align with go-fdo-server rpm builds #41
Conversation
kgiusti
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice improvement!
runcom
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm (but probably pending the go-fdo bump + use of go1.25)
f45eca6 to
9f63fe3
Compare
|
if you've rebased, the to0 call is now gone and tests need to be adapted unfortunately |
7304be0 to
bfcbddf
Compare
ffd9cb9 to
aa560b0
Compare
|
Failed to load packit config file: For more info, please check out the documentation or contact the Packit team. You can also use our CLI command |
34df1ef to
71aa948
Compare
4883a80 to
0a8c4f4
Compare
0a8c4f4 to
9f61c4d
Compare
|
tests still failing with |
b44a936 to
fed6666
Compare
fed6666 to
e84bbaf
Compare
| export GO_VENDOR_TOOLS_CONFIG=${BASE_DIR}/go-vendor-tools.toml | ||
| export SPEC_FILE=${BASE_DIR}/go-fdo-client.spec | ||
| # Download the source tarball (Source0) needed by go_vendor_archive | ||
| spectool -g -C ${BASE_DIR} ${SPEC_FILE} || exit 1 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The spec file used here doesn't have commit/version/release modified (it seems it's using the hardcoded commit value) see https://dashboard.packit.dev/jobs/propose-downstream/22467
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, it looks like fix-spec-file does not apply to propose-downstream action, we need to modify the commit hash in the post-upstream-clone or pre-sync hooks. See: https://packit.dev/docs/configuration/actions
004edb2 to
0ebada2
Compare
Signed-off-by: Miguel Martín <[email protected]>
0ebada2 to
adb264b
Compare
Build the
go-fdo-clientRPMs in the same way asgo-fdo-serverones