Updating To latest version of sqlite3 to fix s3 url issue #10
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Owner
|
Version 1.1.2 now uses the latest sqlite3 release (5.0.2). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This address a few issues fixed in sqlite3 5.0.0. Mainly the issue regarding the s3 URL having a typo in it. You can find the full change log here. https://github.com/mapbox/node-sqlite3/blob/master/CHANGELOG.md If that failed to download it would fall back to building from source. I myself had a problem building from source on OS Mac Big Sur so I wanted to update this library with the fixes in 5.0.1
Broken Link Fix TryGhost/node-sqlite3#1369