see-other-players with Proper movement packets and File logging#155
Conversation
| let mut position = conn_id.get_mut::<Position>(&state)?; | ||
| trace!("Got position 1 for player move"); | ||
|
|
||
| delta_pos = Some(( |
There was a problem hiding this comment.
SIMD might help here? would suggest benchmarking first tho
There was a problem hiding this comment.
I don't think it should matter that much, and maybe a micro-optimization? SIMD, as far as I know, has overhead, so maybe not worth it.
There was a problem hiding this comment.
I don't think it should matter that much, and maybe a micro-optimization? SIMD, as far as I know, has overhead, so maybe not worth it.
Yeah I think SIMD only helps when you have a lot of elements
| } | ||
| }; | ||
|
|
||
| broadcast(&packet, state, BroadcastOptions::default().all()).await?; |
There was a problem hiding this comment.
Should limit this to only players that can see them
There was a problem hiding this comment.
Should limit this to only players that can see them
Imo probably should be done in a different pr the previous one that used teleport didn't only send it in range either iirc although probably wouldn't be hard to fix here
There was a problem hiding this comment.
I'm waiting for chunks shit to be more stable to add a regional entity system. So we can have lookup for entities in a radius with the ECS. Right now, we don't have much choice, other than literally looping through every living entity and finding the closest one.
|
|
||
| let is_verbose = trace_level > Level::INFO; | ||
|
|
||
| let file_layer = { |
There was a problem hiding this comment.
Could we also have a latest.txt that is overwritten every time the server boots up?
There was a problem hiding this comment.
Yeah definitely possible. I'm using tracing-appender library right now, with builtin shit. I'll figure it out by tomorrow hopefully.
3 participants
Proper movement packets (change pos, change pos & rot, change rot, teleport) and File logging.
Description
^
Motivation and Context
It's required cuz I didn't implement the additional less bandwith taking packets before. And file logging is needed because why wouldn't we need file logging?
How has this been tested?
uh
Screenshots (if appropriate):
👍
Types of changes
Checklist: