Colors lost when dragging tab to new window

[TheLastZombie]

When a tab contains code colored using ANSI escape sequences and it is dragged to create a new window, the colors are lost.

Here's the file I used in the preview above: https://gist.github.com/mlocati/fdabcaeb8071d5c75a2d51712db24011

[felixse]

Yes, this is a known restriction. It can be fixed once xtermjs/xterm.js#2369 is merged

[JavaCS3]

Yes, this is a known restriction. It can be fixed once xtermjs/xterm.js#2369 is merged

The serialize-addon is not mature currently. Serializing API may change in the future. Anyway, I'm glad my plugin can fix this problem.

BTW, What happened when a tab is dragged out. Can you show me where the code is? Maybe it will help me to design a better API for that addon

[maxhora]

Hey @JavaCS3 current "temporary" solution in Fluent is based exactly on your source code ( I believe I have mentioned you by nickname when created PR with your source code ). It seems I've modified plugin's source code slightly to match Fluent needs, but can't remember for sure right now what changes were made.

[maxhora]

impl is there https://github.com/felixse/FluentTerminal/blob/master/FluentTerminal.Client/src/xterm-addon-serialize/src/SerializeAddon.ts#L21

[JavaCS3]

After I took a quick look at the impl, I found the answer.
Whenever a tab is teared off. It will call the serialize addon to dump the internal xterm.js state into a string. And restore that state whenever it's needed.

FluentTerminal/FluentTerminal.App/App.xaml.cs

Lines 671 to 677 in d1bf356

	private async void OnTabTearOff(object sender, TerminalViewModel model)
	{
	Logger.Instance.Debug("App.xaml.cs on tab tear off");
	var newViewModel = await CreateNewTerminalWindowAsync();
	await newViewModel.AddTabAsync(await model.SerializeAsync(), 0);
	}

FluentTerminal/FluentTerminal.App.ViewModels/TerminalViewModel.cs

Lines 43 to 78 in d1bf356

	public async Task<string> SerializeAsync()
	{
	TerminalState state = new TerminalState
	{
	HasCustomTitle = _hasCustomTitle,
	ShellTitle = ShellTitle,
	TabTitle = TabTitle,
	TerminalTheme = TerminalTheme,
	TabTheme = TabTheme,
	ShowSearchPanel = ShowSearchPanel,
	SearchText = SearchText,
	XtermBufferState = await SerializeXtermStateAsync().ConfigureAwait(false),
	TerminalId = Terminal.Id,
	ShellProfile = ShellProfile
	};
	return JsonConvert.SerializeObject(state);
	}
	public void Restore(string data)
	{
	TerminalState state = JsonConvert.DeserializeObject<TerminalState>(data);
	if (state != null)
	{
	_hasCustomTitle = state.HasCustomTitle;
	ShellTitle = state.ShellTitle;
	TabTitle = state.TabTitle;
	TerminalTheme = state.TerminalTheme;
	TabTheme = state.TabTheme;
	ShowSearchPanel = state.ShowSearchPanel;
	SearchText = state.SearchText;
	XtermBufferState = state.XtermBufferState;
	_terminalId = state.TerminalId;
	ShellProfile = state.ShellProfile;
	}
	}