Adding p as timezone offset, e.g. +02:00
#149
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@fboes Yay! Thanks dude, awesome PR, great new feature! Have added some comments, once those resolved and the CI build passes, will merge and release a new version to npm 😄 |
|
@chase-manning Do I have to open a new pull request to fix my typos? |
|
@fboes I merged anyway as not a big deal 😄 If you want to create another PR for the typos then got for it, but all good if not. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Because the feed validator for ATOM complains about timezone offset being given as
+0200and not as+02:00, I added a slight modification of theoand called itp(like in PHP's date function).I ended up killing my original pull request at #56 (please close that) and building a completely new fix.
Cheers & thanks for this great lib,
Frank
closes: #148
closes: #81