Fix for angle misclassification due to low floating point precision#9
Open
nagarabh wants to merge 2 commits intofedassa:masterfrom
Open
Fix for angle misclassification due to low floating point precision#9nagarabh wants to merge 2 commits intofedassa:masterfrom
nagarabh wants to merge 2 commits intofedassa:masterfrom
Conversation
Conversion to floating point makes the values imprecise and is not required especially when the remaining code is in double precision.
The condition "inclination > DEG_90_TO_RAD" needs to be checked upto a precision of 1e-15 (https://en.wikipedia.org/wiki/IEEE_754#/media/File:IEEE754.svg) otherwise assertions on lines 712 or 724 may fail leading to memory access violation error on lines 713/725.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hope that resolves the issue for good.
Regards,
Abhishek