add Secret Store implementation#19
Merged
Merged
Conversation
Member
Author
|
Still to do: Viceroy doesn't have support for these hostcalls yet, so the example is expected to fail on it. Looks like we need an integration test for it as well (which I would expect to fail for now). |
Member
Author
|
Viceroy PR: fastly/Viceroy#210 |
3c058bd to
2c4b7cf
Compare
00ac085 to
9ddfe44
Compare
This adds hostcall and SDK support for the Fastly Secret Store. An
example is included for usage but the basic idea is:
```go
st, err := secretstore.Open("example_secretstore")
if err != nil {
panic(err)
}
s, err := st.Get("my_secret")
if err != nil {
panic(err)
}
pt, err := s.Plaintext()
if err != nil {
panic(err)
}
fmt.Fprintf(w, "secret value: %q", v)
```
9ddfe44 to
ee90fe3
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds hostcall and SDK support for the Fastly Secret Store. An
example is included for usage but the basic idea is: