Add manifest_version validation to fastly.toml parsing.#590
Merged
Conversation
dgohman-fastly
force-pushed
the
dgohman-fastly/manifest-version
branch
from
02c5bc9 to
2e73e7e
Compare
dgohman-fastly
force-pushed
the
dgohman-fastly/manifest-version
branch
from
9365518 to
c85574c
Compare
chenyan2002
previously approved these changes
Mar 25, 2026
To support using the `manifest_version` field of fast.toml for future-proofing, issue an error if this field contains a version greater than the greatest version we recognize. Also, remove the `semver` dependency, as the version field as [documented] is an integer. [documented]: https://www.fastly.com/documentation/reference/compute/fastly-toml/
dgohman-fastly
force-pushed
the
dgohman-fastly/manifest-version
branch
from
c85574c to
a7c4ce2
Compare
dgohman-fastly
force-pushed
the
dgohman-fastly/manifest-version
branch
from
a7c4ce2 to
676bf7f
Compare
chenyan2002
approved these changes
Mar 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
To support using the
manifest_versionfield of fast.toml for future-proofing, issue an error if this field contains a version greater than the greatest version we recognize.Also, remove the
semverdependency, as the version field as documented is an integer.