Update to edition 2024.#588
Merged
Merged
Conversation
dgohman-fastly
requested review from
angelo-tmc and
chenyan2002
and removed request for
angelo-tmc
chenyan2002
previously approved these changes
Mar 2, 2026
This is mostly auto-generated by `cargo fix --edition` and `cargo fmt`, but I did make a few manual changes to avoid using the `expr_2021` compatibility construct and to add safety comments to `unsafe` blocks around `std::env::set_var` calls, which are unsafe now.
dgohman-fastly
force-pushed
the
dgohman-fastly/edition-2024
branch
from
1c9383b to
5c7858e
Compare
chenyan2002
approved these changes
Mar 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is mostly auto-generated by
cargo fix --editionandcargo fmt, but I did make a few manual changes to avoid using theexpr_2021compatibility construct and to add safety comments tounsafeblocks aroundstd::env::set_varcalls, which are unsafe now.