Merged
Conversation
Contributor
|
Just double-checking re: the intended MSRV, because the current commit has 1.87 rather than 1.88. |
3db47c8 to
8636292
Compare
Contributor
Author
Oops, I put the wrong thing in the PR description. I've fixed that to say 1.87, and also updated |
dmartin
previously approved these changes
Jan 20, 2026
dmartin
previously approved these changes
Jan 20, 2026
Contributor
Author
|
I've bumped the versions to |
dmartin
approved these changes
Jan 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR updates the lockfiles and
CHANGELOG.mdper the release instructions, in preparation for the next Viceroy release.I have also updated the MSRV to 1.87 in
Cargo.tomlandrust-toolchain.toml, since runningmake generate-lockfilesnoted that some of the dependencies declare theirs to be 1.87. (Although it's not clear if that's actually true, since everything built and the tests ran fine with Rust 1.86.)