Skip to content

Add a CI script to test different Rust verisions.#556

Merged
dgohman-fastly merged 2 commits into
mainfrom
dgohman-fastly/test-rust
Nov 20, 2025
Merged

Add a CI script to test different Rust verisions.#556
dgohman-fastly merged 2 commits into
mainfrom
dgohman-fastly/test-rust

Conversation

@dgohman-fastly
Copy link
Copy Markdown
Contributor

No description provided.

Comment thread .github/workflows/rust.yml Fixed
posborne
posborne previously approved these changes Nov 17, 2025
Copy link
Copy Markdown
Member

@posborne posborne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, one gap that I could see is if there was a regression that is in some way dependent on runtime interactions between:

  1. A specific test.
  2. A specific version of the fastly(*) crates.
  3. A specific/newer version of the rust compiler.

I don't think that is particularly likely, but it's an extreme edge case that did come to mind.

Comment thread .github/workflows/rust.yml Dismissed
@dgohman-fastly
Copy link
Copy Markdown
Contributor Author

I agree, this is just a starting point, and we can extended it to test more things over time.

@dgohman-fastly dgohman-fastly merged commit 2aed402 into main Nov 20, 2025
13 checks passed
@dgohman-fastly dgohman-fastly deleted the dgohman-fastly/test-rust branch November 20, 2025 00:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants