add support for reading secrets from a JSON file#428
Merged
Conversation
cee-dub
reviewed
Sep 17, 2024
Member
cee-dub
left a comment
cee-dub
left a comment
There was a problem hiding this comment.
Just a couple spelling corrections from me. I didn’t see any obvious issues with the Rust, but I’m still learning it, so I don’t feel qualified to give a ✅.
Co-authored-by: Cameron Walters (cee-dub) <cameron.walters@gmail.com>
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This uses the same format as for the KV store, introduced in #365.
Fixes #364.