Update compute.wit and the adapter for some api fixes#414
Merged
Conversation
elliottt
force-pushed
the
trevor/update-compute-wit
branch
from
a73b23d to
8826778
Compare
acw
approved these changes
Aug 13, 2024
Contributor
acw
left a comment
acw
left a comment
There was a problem hiding this comment.
Oh, I like some of these much better.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
While implementing compute.wit elsewhere, I made a few changes that better reflect the translation to the underlying hostcalls. This PR backports those changes to compute.wit, and folds them in to the adapter and component implementation.