🎁 Prepare release v0.10.0#404
Conversation
acfoltzer
left a comment
There was a problem hiding this comment.
It looks like this needs to be a major version bump to 0.10.0, as the viceroy-lib public interface includes types from wasmtime which got a major bump. There are also a couple of public definitions within the crate itself whose types have changed.
Given the large surface area of exports from the viceroy-lib crate, we might want to consider a policy similar to Wasmtime of just making a major bump on every release in order to avoid accidental semver breaks. Or making many more things private to limit the surface area we have to audit when deciding on the next release's version.
|
That makes sense! I've bumped the |
acfoltzer
left a comment
There was a problem hiding this comment.
+1 to release per step 6 of the release process 🚀
Yeah, the tag name is what counts |
|
EDIT: It actually just needed a |
The `viceroy-component-adapter` does not need to be built in the release builds, since it is meant to be rebuilt with `make adapter` and then have the generated WASM binary under `lib/data/` committed.
|
Hmm, glad you found a workaround, but flagging this for @elliottt when he's back. There's definitely some awkwardness about having the adapter where it currently sits. |
|
02a15e6 adds |
acfoltzer
left a comment
There was a problem hiding this comment.
LGTM; thank you for navigating this unusual release!
This updates the lockfiles with
make generate-lockfileas mentioned in RELEASING.md, and updates theCHANGELOG.mdto include the commits added since #375.Rendered view of the changelog is here.