Add device detection hostcall#330
Merged
Merged
Conversation
This is closely patterned on the geolocation hostcall. The new test that executes the hostcall needs a new SDK, so this will be followed by a separate commit that comments it out. That can be reverted once the new SDK is available.
These tests depend on a new SDK for the device_detection hostcall, comment them out for now. This is in its own commit to make it easy to revert.
acfoltzer
suggested changes
Nov 6, 2023
Contributor
acfoltzer
left a comment
acfoltzer
left a comment
There was a problem hiding this comment.
Just a small copypaste fix, then ready to go
| @@ -1,13 +1,13 @@ | |||
| use fastly::{Backend, Error, Request}; | |||
Contributor
There was a problem hiding this comment.
Huh, the formatting step in CI must be missing these if rustfmt changed these despite previous successful commits. Something to worry about later
cmckendry
pushed a commit
to 1stdibs/Viceroy
that referenced
this pull request
Feb 8, 2024
* Add hostcall for device_detection. This is closely patterned on the geolocation hostcall. The new test that executes the hostcall needs a new SDK, so this will be followed by a separate commit that comments it out. That can be reverted once the new SDK is available. * device_detection: Temporarily comment out tests that need new SDK. These tests depend on a new SDK for the device_detection hostcall, comment them out for now. This is in its own commit to make it easy to revert. * Minor changes from cargo fmt. * Fix copy/pasted identifier.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add hostcall for device detection, closely patterned on geolocation.
The test that executes the hostcall needs a new SDK, so a second commit comments them out for now. The tests pass locally when built with the new SDK.