Reset the default value for grpc for static backends to false.#311
Merged
Conversation
acfoltzer
previously approved these changes
Sep 18, 2023
Contributor
acfoltzer
left a comment
acfoltzer
left a comment
There was a problem hiding this comment.
In the subsequent PR to land tests for this new flag, can we include a test to avoid a regression?
acw
force-pushed
the
awick/fix-default-backend-grpc
branch
from
cc8bd71 to
0374b89
Compare
cmckendry
pushed a commit
to 1stdibs/Viceroy
that referenced
this pull request
Feb 8, 2024
…tly#311) * Reset the default value for `grpc` for backends to false. * Update the CHANGELOG with the change.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.