Support the new config store hostcalls.#296
Merged
Merged
Conversation
ulyssa
approved these changes
Aug 3, 2023
Member
ulyssa
left a comment
ulyssa
left a comment
There was a problem hiding this comment.
This looks good to me! And I believe that forwarding is the appropriate behaviour for Viceroy. I believe the hostcall's intended difference in xqd is that it doesn't go through the sidecar, which doesn't matter here.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
These work by naively just forwarding the new hostcalls into the underlying dictionary system; these pass the tests, but I'd love someone to confirm (preferably someone named @acfoltzer) that this is intended behavior.