Update to wasmtime 3.0 and enable wasi-nn calls#209
Merged
Conversation
geekbeast
force-pushed
the
feature/wasi-nn
branch
from
8c09cbb to
245390e
Compare
geekbeast
force-pushed
the
feature/wasi-nn
branch
from
27b3eaf to
1a2b813
Compare
Contributor
|
I think we'll want to guard the availability of wasi-nn behind a CLI flag, so that (as our testing tool) we don't create the expectation that wasi-nn is available in production |
added 8 commits
December 6, 2022 14:38
There are now two flavors of the handle request call. One is used for trap_test and the other is used by the Viceroy framework. Also extended the call to bubble up the error so it could be easily included in the response body.
Contributor
|
I have implemented enabling experimental modules via flags and refactored the trap test so that it uses the body instead of headers. |
added 2 commits
December 6, 2022 20:14
Also switches backtrace output to stderr.
mgattozzi
reviewed
Jan 13, 2023
Contributor
mgattozzi
left a comment
mgattozzi
left a comment
There was a problem hiding this comment.
Hey @geekbeast just one change needed for the error output and then a question on a thing that seemed turned off. This looks great otherwise. If there's a test you can do to show it working that would be great, but given that it's experimental support I'm not going to require it to approve!
mgattozzi
approved these changes
Jan 17, 2023
Contributor
mgattozzi
left a comment
mgattozzi
left a comment
There was a problem hiding this comment.
Thanks for taking the time to get all these in!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The main purpose of this PR was to support wasi-nn calls inside Viceroy. As the necessary changes weren't available until the wasmtime 3.0 release, I also made the updates to to make it compatible with the broader changes in that specific release.
The two big changes that came in were changes to the pattern for PoolingAllocationConfig and how error/traps are handled. There was also one minor change in that it looks like the linker is no longer under the tokio namespace.