Add stat for clock runtime#121
Conversation
cratelyn
left a comment
cratelyn
left a comment
There was a problem hiding this comment.
nice work @djKooks! i have just a small pair of nitpicks about variable names. otherwise, this looks great 🙂
| ) -> Result<(), ExecutionError> { | ||
| info!("handling request {} {}", req.method(), req.uri()); | ||
|
|
||
| let now = Instant::now(); |
There was a problem hiding this comment.
how about renaming this variable ever so slightly, to something like...
| let now = Instant::now(); | |
| let start_timestamp = Instant::now(); |
| .expect("`memory` is exported") | ||
| .size(&store); | ||
|
|
||
| let distant = Instant::now().duration_since(now); |
There was a problem hiding this comment.
...and similarly, a slight name tweak
| let distant = Instant::now().duration_since(now); | |
| let request_duration = Instant::now().duration_since(start_timestamp); |
| bytesize::ByteSize::kib(heap_pages as u64 * 64) | ||
| ); | ||
|
|
||
| info!("request completed in {:?}", distant); |
There was a problem hiding this comment.
same rename as above, just applying it here so you can fix this with the click of a mouse 🖱️
| info!("request completed in {:?}", distant); | |
| info!("request completed in {:?}", request_duration); |
|
@cratelyn updated 🙏 |
|
this looks like it's almost ready to go @djKooks! there's currently a hiccup in CI here that was addressed in #123. if you rebase this branch on the current |
|
@cratelyn got it. Updated~ |
cratelyn
left a comment
cratelyn
left a comment
There was a problem hiding this comment.
thank you so much @djKooks! this looks great 🙂
2 participants
Following #76
(please ignore branch/commit name...)