-
-
Notifications
You must be signed in to change notification settings - Fork 70
feat: move /organisations to /organizations #200
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: move /organisations to /organizations #200
Conversation
mcollina
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
Can we add a redirect somehow? cc @jsumners
|
Do you mean a server side redirect? There's a client side redirect added in the docusaurus config at lines 208-213 |
Uzlopak
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Yes, we can add a page rule in Cloudflare for this (though it will use up one of our three available). |
|
We handle redirects here: website/docusaurus.config.utils.js Line 75 in 37c6dea
but: https://prowritingaid.com/organisation-vs-organization and the previous website stands with |
fa810e4 to
ae3bf16
Compare
|
Could you update the PR? we fixed the deploy to staging. Plus: why we don't add a redirect from |
|
It was because the website uses American English everywhere else |
ae3bf16 to
9cb77dd
Compare
3de85d2 to
8633c45
Compare
|
@10xLaCroixDrinker Could you do a rebase please, and we can get this over the line. 😸 |
|
@Fdawgs sure thing! I can take care of that by EOD Monday |
9cb77dd to
928eaa0
Compare
928eaa0 to
cf4b665
Compare
Description
This PR moves the /organisations route to /organizations and adds a redirect from the old route to the new.
Related Issues
Related to discussion in fastify/fastify#5349
Check List