Skip to content

Conversation

@emicovi
Copy link
Contributor

@emicovi emicovi commented Nov 17, 2025

Summary

  • add a validated recordExceptions option that defaults to the current behavior
  • gate every span.recordException call on that flag while still marking spans as errors
  • document the option and cover it in both JS and TS test suites

Testing

  • npm run test:unit

Fixes #91

Copy link
Member

@gurgunday gurgunday left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@metcoder95
Copy link
Member

Can you fix the conflicts and undo the changes non-related to the span recording flag?

@emicovi emicovi force-pushed the feat/disable-span-exceptions branch from 39534ba to 5b04a21 Compare November 20, 2025 10:46
@emicovi
Copy link
Contributor Author

emicovi commented Nov 20, 2025

Can you fix the conflicts and undo the changes non-related to the span recording flag?

done

@metcoder95 metcoder95 merged commit 9461054 into fastify:main Nov 20, 2025
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

False positives in Datadog Error Tracking for 4xx errors

3 participants