Skip to content

Conversation

@dancamma
Copy link

Closes #498

This PR prevent the action to run with pull_request_target unless the user explicitly provide a skip-trigger-verification config. For more details, see #355

Checklist

@simoneb
Copy link
Collaborator

simoneb commented Oct 11, 2023

Folks we need to converge on an agreement before we go ahead with any implementation. At the moment I'm not sure we reached one yet.

@dancamma dancamma marked this pull request as draft October 11, 2023 10:33
@dancamma
Copy link
Author

Hi @simoneb, I opened this for reference in the thread of #500. I'm converting this to a draft.

@simoneb
Copy link
Collaborator

simoneb commented Jan 8, 2024

Closing this as there is no consensus

@simoneb simoneb closed this Jan 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Fail with meaningful error in case an unsupported trigger is used

2 participants