feat: stop failing action when bump is higher than target and log info instead #424
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
simoneb
approved these changes
May 19, 2023
Collaborator
simoneb
left a comment
simoneb
left a comment
There was a problem hiding this comment.
LGTM. On paper this is a breaking change because it changes an existing behavior from failing the execution to logging a warning, but in practice I believe it's a safe change to do.
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This stops the action from failing when target is not match, just log a message instead.
Resolves #423.
Checklist
npm run testandnpm run benchmarkand the Code of conduct