Skip to content

Merge next into master#241

Merged
jsumners merged 6 commits intomasterfrom
next
Jun 23, 2024
Merged

Merge next into master#241
jsumners merged 6 commits intomasterfrom
next

Conversation

@jsumners
Copy link
Member

As titled.

gurgunday and others added 2 commits February 23, 2024 12:22
* update for v5

* add pre commit
Signed-off-by: Cristian Barlutiu <cristian.barlutiu@gmail.com>
Copy link
Member

@gurgunday gurgunday left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

gurgunday and others added 3 commits June 21, 2024 11:45
* update for v5

* add pre commit
Signed-off-by: Cristian Barlutiu <cristian.barlutiu@gmail.com>
Copy link
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@mcollina
Copy link
Member

CI is failing

@jsumners jsumners requested a review from mcollina June 21, 2024 19:33
@jsumners
Copy link
Member Author

For some reason npm keeps installing the alpha.1 release of Fastify and I just don't have the patience to figure it out today. I'll come back later.

@jsumners jsumners marked this pull request as draft June 21, 2024 19:34
@jsumners
Copy link
Member Author

The only way I could figure out to fix the problem was to mark the mislabeled fastify@5.0.0-aplha.1 version as deprecated.

@jsumners jsumners marked this pull request as ready for review June 23, 2024 15:41
@jsumners jsumners merged commit 1a5a200 into master Jun 23, 2024
@jsumners jsumners deleted the next branch June 23, 2024 15:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants