Conversation
2 tasks
2 tasks
This comment was marked as outdated.
This comment was marked as outdated.
Uzlopak
commented
Jul 18, 2023
2 tasks
Contributor
Author
|
@fastify/typescript Can you have a look please? I am actually highly confident, that this is the solution. |
Member
|
Hey. This approach is new to me: instead of using polymorphism, we are going with a generic inference. I like it! I am wondering if there are other points in the Fastify ecosystem where we can use the same approach (the same one we did with the infamous triplet and the export = thing when we discovered it) |
fox1t
approved these changes
Jul 18, 2023
Member
|
How? Could you open a fresh issue? |
Contributor
Author
Member
yes |
Contributor
Author
|
created an issue #221 |
renovate bot
referenced
this pull request
in specfy/specfy
Aug 4, 2023
[](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [fastify-plugin](https://togithub.com/fastify/fastify-plugin) | [`4.5.0` -> `4.5.1`](https://renovatebot.com/diffs/npm/fastify-plugin/4.5.0/4.5.1) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | --- ### Release Notes <details> <summary>fastify/fastify-plugin (fastify-plugin)</summary> ### [`v4.5.1`](https://togithub.com/fastify/fastify-plugin/releases/tag/v4.5.1) [Compare Source](https://togithub.com/fastify/fastify-plugin/compare/v4.5.0...v4.5.1) #### What's Changed - docs: rename next callback to done to make consistent with core by [@​58bits](https://togithub.com/58bits) in [https://github.com/fastify/fastify-plugin/pull/210](https://togithub.com/fastify/fastify-plugin/pull/210) - chore(.gitignore): add bun lockfile by [@​Fdawgs](https://togithub.com/Fdawgs) in [https://github.com/fastify/fastify-plugin/pull/211](https://togithub.com/fastify/fastify-plugin/pull/211) - build(deps-dev): bump tsd from 0.25.0 to 0.27.0 by [@​dependabot](https://togithub.com/dependabot) in [https://github.com/fastify/fastify-plugin/pull/212](https://togithub.com/fastify/fastify-plugin/pull/212) - build(deps-dev): bump tsd from 0.27.0 to 0.28.0 by [@​dependabot](https://togithub.com/dependabot) in [https://github.com/fastify/fastify-plugin/pull/213](https://togithub.com/fastify/fastify-plugin/pull/213) - build(deps-dev): bump [@​fastify/type-provider-typebox](https://togithub.com/fastify/type-provider-typebox) from 2.4.0 to 3.0.0 by [@​dependabot](https://togithub.com/dependabot) in [https://github.com/fastify/fastify-plugin/pull/214](https://togithub.com/fastify/fastify-plugin/pull/214) - ci: only trigger on pushes to main branches by [@​Fdawgs](https://togithub.com/Fdawgs) in [https://github.com/fastify/fastify-plugin/pull/215](https://togithub.com/fastify/fastify-plugin/pull/215) - build(deps-dev): bump [@​types/node](https://togithub.com/types/node) from 18.16.5 to 20.1.0 by [@​dependabot](https://togithub.com/dependabot) in [https://github.com/fastify/fastify-plugin/pull/216](https://togithub.com/fastify/fastify-plugin/pull/216) - fix inferring the correct fn type by [@​Uzlopak](https://togithub.com/Uzlopak) in [https://github.com/fastify/fastify-plugin/pull/218](https://togithub.com/fastify/fastify-plugin/pull/218) #### New Contributors - [@​58bits](https://togithub.com/58bits) made their first contribution in [https://github.com/fastify/fastify-plugin/pull/210](https://togithub.com/fastify/fastify-plugin/pull/210) **Full Changelog**: fastify/fastify-plugin@v4.5.0...v4.5.1 </details> --- ### Configuration 📅 **Schedule**: Branch creation - "after 4pm on friday,before 9am on monday,every weekend" in timezone Europe/Paris, Automerge - At any time (no schedule defined). 🚦 **Automerge**: Enabled. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://developer.mend.io/github/specfy/specfy). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNi4xMS4wIiwidXBkYXRlZEluVmVyIjoiMzYuMTEuMCIsInRhcmdldEJyYW5jaCI6ImNob3JlL3Jlbm92YXRlQmFzZUJyYW5jaCJ9--> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
lilpoozie2005
approved these changes
Sep 8, 2024
lilpoozie2005
approved these changes
Sep 8, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #217
I got help from @webstrand. Props to him.
It should now work.
According to webstrand
Maybe needs a new paragraph regarding typing in the readme.md were we basically write, that they should not use the generics but specify the types on the parameters, when calling fastifyPlugin?
Checklist
npm run testandnpm run benchmarkand the Code of conduct