Skip to content

Conversation

@ojeytonwilliams
Copy link
Contributor

Checklist

This PR narrows the return type of unsign to better reflect the Signer logic. Specifically, that if unsigning fails the renew property will be false and value will be null, but if it succeeds renew can be boolean, but value can only be a string, never null.

This is consistent with the logic in the default Signer, but it does mean that custom Signers have to use the same high-level logic.

The success and failure cases are distinct and the types can reflect
this.
Copy link
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants