Document design of tier 2 engines #640
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mdboom
reviewed
Jan 3, 2024
Contributor
mdboom
left a comment
mdboom
left a comment
There was a problem hiding this comment.
This is great. I just had a few points where I wasn't quite following that might need elaboration.
3.13/engine.md
Outdated
| so we need to store the offset in the executor. | ||
|
|
||
| Since there is a fixed number of micro-ops allowed in a superblock, we have an uppper | ||
| bound on the offset. We will-preallocate one exit object per possible offset. |
Contributor
There was a problem hiding this comment.
Does "possible offset" here mean all 512 per executor, or just the number of instructions with EXIT_IF in them?
|
|
||
| * The offset/location of the pointer: Implicit if we embed the exit pointer in the exit data | ||
| * The target: Has a maximum value of about 10**9, so store as a `uint32_t` | ||
| * Any relevant known type information: Format TBD. |
Contributor
There was a problem hiding this comment.
Am I correct that this is only needed for intra-executor optimization and thus could be deferred until we start working on that?
Co-authored-by: Michael Droettboom <[email protected]> Co-authored-by: Jelle Zijlstra <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.