Skip to content

🚸 Mark login field as required #1166

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 12, 2024
Merged

🚸 Mark login field as required #1166

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
839d12b
🚸 Mark username and password as required
patrick91 Apr 10, 2024
59b2a4e
🥅 Handle validation errors
patrick91 Apr 10, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions frontend/src/hooks/useAuth.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,6 +43,10 @@ const useAuth = () => {
errDetail = err.message
}

if (Array.isArray(errDetail)) {
errDetail = "Something went wrong"
Comment on lines +46 to +47
Copy link
Contributor Author

@patrick91 patrick91 Apr 10, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is usually when getting a pydantic validation error.

It would be nice to make the error to each field, but it's not straightforward 😊

}

setError(errDetail)
},
})
Expand Down
2 changes: 2 additions & 0 deletions frontend/src/routes/login.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -92,6 +92,7 @@ function Login() {
})}
placeholder="Email"
type="email"
required
/>
{errors.username && (
<FormErrorMessage>{errors.username.message}</FormErrorMessage>
Expand All @@ -103,6 +104,7 @@ function Login() {
{...register("password")}
type={show ? "text" : "password"}
placeholder="Password"
required
/>
<InputRightElement
color="ui.dim"
Expand Down