feat: impl several traits for OnceCell #79
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: tison <[email protected]>
matthiaskrgr
added a commit
to matthiaskrgr/rust
that referenced
this pull request
Nov 25, 2025
…yukang Simplify OnceCell Clone impl Noticed when developing fast/mea#79. This may also apply to `OnceLock`. But unfortunately, we can't construct a completed `Once` beforehand. Note that `OnceCell::from` is marked as [`rustc_const_unstable`](rust-lang#143773) so we don't need an extra `const fn from_value` to leverage possible const convert benefit.
rust-timer
added a commit
to rust-lang/rust
that referenced
this pull request
Nov 25, 2025
Rollup merge of #149305 - tisonkun:oncecell-simplify, r=chenyukang Simplify OnceCell Clone impl Noticed when developing fast/mea#79. This may also apply to `OnceLock`. But unfortunately, we can't construct a completed `Once` beforehand. Note that `OnceCell::from` is marked as [`rustc_const_unstable`](#143773) so we don't need an extra `const fn from_value` to leverage possible const convert benefit.
github-actions bot
pushed a commit
to rust-lang/compiler-builtins
that referenced
this pull request
Nov 27, 2025
Simplify OnceCell Clone impl Noticed when developing fast/mea#79. This may also apply to `OnceLock`. But unfortunately, we can't construct a completed `Once` beforehand. Note that `OnceCell::from` is marked as [`rustc_const_unstable`](rust-lang/rust#143773) so we don't need an extra `const fn from_value` to leverage possible const convert benefit.
github-actions bot
pushed a commit
to model-checking/verify-rust-std
that referenced
this pull request
Jan 19, 2026
…yukang Simplify OnceCell Clone impl Noticed when developing fast/mea#79. This may also apply to `OnceLock`. But unfortunately, we can't construct a completed `Once` beforehand. Note that `OnceCell::from` is marked as [`rustc_const_unstable`](rust-lang#143773) so we don't need an extra `const fn from_value` to leverage possible const convert benefit.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This refers to #77