Add linting rules in CI using Ruff#657
Merged
enricostragiotti merged 26 commits intomasterfrom Nov 18, 2025
Merged
Conversation
…s_UP_RET_FBT_FA_PTH
…T_FBT_FA_PTH Ruff newrules UP RET FBT FA PTH
…ply with RUFF rules
Ruff linting it2
|
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## master #657 +/- ##
==========================================
+ Coverage 91.65% 91.90% +0.25%
==========================================
Files 99 99
Lines 6265 6249 -16
Branches 821 809 -12
==========================================
+ Hits 5742 5743 +1
+ Misses 353 340 -13
+ Partials 170 166 -4 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Contributor
Author
|
Hello @florentLutz and @esnguyenvan, I completed the assembly of the two linting rules iterations. I do not think that we should redo any review, so this PR is just FYI. |
esnguyenvan
approved these changes
Nov 14, 2025
Contributor
esnguyenvan
left a comment
esnguyenvan
left a comment
There was a problem hiding this comment.
OK, let's give it a try!
florentLutz
approved these changes
Nov 14, 2025
Contributor
Author
|
I'll merge this one just after we merged #649 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary of Changes
See #609 and #634
Now in codacy we are not using pylint anymore
Additional changes
The Ruff configuration (
ruff.toml) has been moved out ofpyproject.tomlto keep things clean and readable, as the configuration is expected to grow over time.Related Issues
closes #610 and closes #611
New Dependencies
Ruff version 0.14.4