Skip to content

[chore] Add Node 22 to test matrix#2033

Merged
sds merged 1 commit into
mainfrom
sds/add-node-22
Jun 9, 2024
Merged

[chore] Add Node 22 to test matrix#2033
sds merged 1 commit into
mainfrom
sds/add-node-22

Conversation

@sds
Copy link
Copy Markdown
Contributor

@sds sds commented Jun 7, 2024

Motivation

We eventually want to release hubs on Node 22, since it's been out for a while.

Merge Checklist


PR-Codex overview

This PR updates the app version determination method, adjusts CI configurations for ARM support, and refactors the app version retrieval in hubble.ts.

Detailed summary

  • Updated app version determination method in hubble.ts
  • Adjusted CI configurations for ARM support
  • Refactored app version retrieval using manual JSON parsing

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

@vercel
Copy link
Copy Markdown

vercel Bot commented Jun 7, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
hub-monorepo ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 9, 2024 7:43am

@changeset-bot
Copy link
Copy Markdown

changeset-bot Bot commented Jun 7, 2024

🦋 Changeset detected

Latest commit: 8e84652

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@farcaster/hubble Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

To get tests to pass, we had to remove the experimental `assert` import
Unfortunately, this is backwards incompatible with old node versions, so
we had to switch to parsing the file directly rather than using `import`
at all.
@sds sds force-pushed the sds/add-node-22 branch from 3a603db to 8e84652 Compare June 9, 2024 07:42
@sds sds enabled auto-merge (squash) June 9, 2024 07:43
@sds sds merged commit 35d395f into main Jun 9, 2024
@sds sds deleted the sds/add-node-22 branch June 9, 2024 07:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

t-chore Miscellaneous improvements

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant