readme: use prefixed method names #310
Conversation
| ### Foldable | ||
|
|
||
| 1. `u.reduce` is equivalent to `u.reduce((acc, x) => acc.concat([x]), []).reduce` | ||
| 1. `u['fantasy-land/reduce']` is equivalent to `u['fantasy-land/reduce']((acc, x) => acc.concat([x]), []).reduce` |
There was a problem hiding this comment.
We really do want .concat and .reduce here because we're referring to Array#concat and Array#reduce.
| 3. If `a['fantasy-land/equals'](b)` and `b['fantasy-land/equals'](c)`, then `a['fantasy-land/equals'](c)` (transitivity) | ||
|
|
||
| #### `equals` method | ||
| <a name="equals-method"></a> |
There was a problem hiding this comment.
As far as I'm aware GitHub does not provide a way to customize a heading's fragment identifier.
|
@davidchambers this makes a lot of sense to me, but as an observer tracking what people think about FL, I think it might be a bit of a public relations problem. As it is today, a lot of libraries are de facto partially compatible with FL. After the change, most of them will no longer be ( |
|
@xaviervia, the spec has required prefixed method names since #146 was released in v1.0.0 back in 2016. This pull request just updates the documentation to make this existing requirement apparent. p.s. I'm not holding my breath waiting for Ramda to fully support Fantasy Land. |
|
Right! Then it would be great to do this, since I was not aware of that
requirement and I might not have been the only one missing that
…On Thu, Feb 28, 2019, 6:48 PM David Chambers ***@***.*** wrote:
@xaviervia <https://github.com/xaviervia>, the spec has required prefixed
method names since #146
<#146> was released in
v1.0.0 <https://github.com/fantasyland/fantasy-land/releases/tag/v1.0.0>
back in 2016. This pull request just updates the documentation to make this
existing requirement apparent.
*p.s. I'm not holding my breath waiting for Ramda to fully support Fantasy
Land.*
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#310 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AAXSroRmlZaDgAG8zyXtZ9JxdtITZsQQks5vSBZcgaJpZM4a-a2i>
.
|
2 participants
These changes make the document clearer but uglier. Clarity trumps beauty, in this context.
👍 / 👎 ?