Conversation
euaaaio
force-pushed
the
formatter-option
branch
from
85bdb3c to
a435799
Compare
euaaaio
force-pushed
the
formatter-option
branch
2 times, most recently
from
03769f9 to
6109030
Compare
euaaaio
force-pushed
the
formatter-option
branch
from
6109030 to
1aa5fb9
Compare
There was a problem hiding this comment.
Pull request overview
This PR introduces a new formatter option to replace the deprecated prettier and stylistic options, providing a more unified and flexible approach to code formatting configuration.
- Adds a new
formatteroption that accepts'stylistic','prettier',false, or an object with stylistic configuration - Maintains backward compatibility by supporting deprecated options with console warnings
- Updates type definitions to mark old options as deprecated and define the new
FormatterOptionstype
Reviewed changes
Copilot reviewed 7 out of 10 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
| src/utils/index.js | Adds resolveFormatter function to normalize formatter options and handle deprecated options with warnings |
| src/index.js | Integrates resolveFormatter, removes deprecated option extraction, and passes resolved options to config functions |
| src/index.d.ts | Defines new FormatterOptions type and marks prettier and stylistic options as deprecated |
| src/configs/vue.js | Updates to use usePrettier instead of prettier, moves vue/define-macros-order rule to always-enabled section, updates comment |
| src/configs/vue.d.ts | Updates interface to use usePrettier instead of separate prettier and stylistic options |
| src/configs/astro.js | Updates to use useStylistic instead of stylistic parameter |
| src/configs/astro.d.ts | Updates interface to use useStylistic instead of stylistic |
| eslint.config.js | Updates config to use new formatter option with nested structure |
| docs/oxlint/UNSUPPORTED-RULES.md | Reorders vue/define-macros-order entry in the list |
| README.md | Updates documentation to describe new formatter option with examples |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.