Fix: Display link orientation in model coordinate space#20
Open
LueApp wants to merge 1 commit intofan-ziqi:mainfrom
Open
Fix: Display link orientation in model coordinate space#20LueApp wants to merge 1 commit intofan-ziqi:mainfrom
LueApp wants to merge 1 commit intofan-ziqi:mainfrom
Conversation
…ree.js world space The hover info panel was using getWorldQuaternion() which includes the internal Z-up to Y-up coordinate conversion from the world wrapper object. This caused a URDF base link with identity orientation to display as quat(0.7071, 0, 0, 0.7071) instead of the expected quat(0, 0, 0, 1). Strip the world wrapper's coordinate system rotation from displayed position and orientation values so they reflect the model's native coordinate frame. Co-Authored-By: Claude <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
quat(0, 0, 0, 1)instead ofquat(0.7071, 0, 0, 0.7071)Test plan
(0, 0, 0, 1)when no rotation is specified🤖 Generated with Claude Code