Skip to content

Conversation

@Shinigami92
Copy link
Member

No description provided.

@Shinigami92 Shinigami92 added this to the v10.0 milestone Jul 4, 2025
@Shinigami92 Shinigami92 self-assigned this Jul 4, 2025
@Shinigami92 Shinigami92 requested a review from a team as a code owner July 4, 2025 15:02
@Shinigami92 Shinigami92 added c: refactor PR that affects the runtime behavior, but doesn't add new features or fixes bugs breaking change Cannot be merged when next version is not a major release labels Jul 4, 2025
@Shinigami92 Shinigami92 force-pushed the refactor-remove-deprecations branch from a0fb9a1 to 10c8983 Compare July 4, 2025 15:02
@netlify
Copy link

netlify bot commented Jul 4, 2025

Deploy Preview for fakerjs ready!

Name Link
🔨 Latest commit a0fb9a1
🔍 Latest deploy log https://app.netlify.com/projects/fakerjs/deploys/6867ecf839ff210008ab91d5
😎 Deploy Preview https://deploy-preview-3553.fakerjs.dev
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@netlify
Copy link

netlify bot commented Jul 4, 2025

Deploy Preview for fakerjs ready!

Name Link
🔨 Latest commit d02a4f7
🔍 Latest deploy log https://app.netlify.com/projects/fakerjs/deploys/686817c9d7a60700089e5dc6
😎 Deploy Preview https://deploy-preview-3553.fakerjs.dev
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@codecov
Copy link

codecov bot commented Jul 4, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.96%. Comparing base (160960b) to head (d02a4f7).
Report is 1 commits behind head on next.

Additional details and impacted files
@@            Coverage Diff             @@
##             next    #3553      +/-   ##
==========================================
- Coverage   99.97%   99.96%   -0.01%     
==========================================
  Files        2888     2888              
  Lines      222112   221958     -154     
  Branches      952      927      -25     
==========================================
- Hits       222059   221889     -170     
- Misses         53       69      +16     
Files with missing lines Coverage Δ
src/faker.ts 100.00% <ø> (ø)
src/modules/date/index.ts 100.00% <ø> (ø)
src/modules/finance/index.ts 100.00% <ø> (ø)
src/modules/helpers/eval.ts 94.21% <100.00%> (-0.49%) ⬇️
src/modules/image/index.ts 100.00% <ø> (ø)
src/modules/internet/index.ts 100.00% <ø> (ø)

... and 2 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@Shinigami92 Shinigami92 force-pushed the refactor-remove-deprecations branch 2 times, most recently from 1bbc823 to c648f68 Compare July 4, 2025 16:20
@xDivisionByZerox
Copy link
Member

There is also the deprecation of eval with function invocations on properties that should be removed:

// TODO @ST-DDT 2023-12-11: Replace in v10
// typeof entrypoint === 'function' ? entrypoint(...params) : undefined

Also, see these "deprecated" parts that add additional JS support that where aimed to be removed in v10:

  • // TODO @matthewmayer 2023-03-27: Consider removing in v10 as this check is only needed in JS
    if (options == null || options.from == null || options.to == null) {
    throw new FakerError(
    'Must pass an options object with `from` and `to` values.'
    );
    }
  • // TODO @matthewmayer 2023-03-27: Consider removing in v10 as this check is only needed in JS
    if (options == null || options.from == null || options.to == null) {
    throw new FakerError(
    'Must pass an options object with `from` and `to` values.'
    );
    }
  • // TODO @ST-DDT 2024-03-17: Remove check in v10
    const optionsSet = [originalMin, originalMax, originalMode].filter(
    (x) => x != null
    ).length;
    if (optionsSet % 3 !== 0) {
    throw new FakerError(
    "The 'min', 'max', and 'mode' options must be set together."
    );
    }

@xDivisionByZerox
Copy link
Member

Oh it seems you missed the workaround for "userName" in the documentation component:

<!-- TODO @ST-DDT 2024-09-25: Remove this in v10 -->
<a
:href="
item.link +
'#' +
(h.anchor === 'userName' ? 'username-1' : slugify(h.anchor))
"
:class="{ deprecated: h.deprecated }"
>{{ h.text }}</a
>

@Shinigami92
Copy link
Member Author

Shinigami92 commented Jul 4, 2025

Oh it seems you missed the workaround for "userName" in the documentation component:

<!-- TODO @ST-DDT 2024-09-25: Remove this in v10 -->
<a
:href="
item.link +
'#' +
(h.anchor === 'userName' ? 'username-1' : slugify(h.anchor))
"
:class="{ deprecated: h.deprecated }"
>{{ h.text }}</a
>

tbh I currently don't know "how" to resolve this

Edit: nevermind, now I got it...

@Shinigami92
Copy link
Member Author

There is also the deprecation of eval with function invocations on properties that should be removed:

// TODO @ST-DDT 2023-12-11: Replace in v10
// typeof entrypoint === 'function' ? entrypoint(...params) : undefined

Also, see these "deprecated" parts that add additional JS support that where aimed to be removed in v10:

  • // TODO @matthewmayer 2023-03-27: Consider removing in v10 as this check is only needed in JS
    if (options == null || options.from == null || options.to == null) {
    throw new FakerError(
    'Must pass an options object with `from` and `to` values.'
    );
    }
  • // TODO @matthewmayer 2023-03-27: Consider removing in v10 as this check is only needed in JS
    if (options == null || options.from == null || options.to == null) {
    throw new FakerError(
    'Must pass an options object with `from` and `to` values.'
    );
    }
  • // TODO @ST-DDT 2024-03-17: Remove check in v10
    const optionsSet = [originalMin, originalMax, originalMode].filter(
    (x) => x != null
    ).length;
    if (optionsSet % 3 !== 0) {
    throw new FakerError(
    "The 'min', 'max', and 'mode' options must be set together."
    );
    }

I just searched for until: 10 parts 👀

@Shinigami92 Shinigami92 force-pushed the refactor-remove-deprecations branch 2 times, most recently from 18bf5a0 to 66a5504 Compare July 4, 2025 17:47
@Shinigami92 Shinigami92 force-pushed the refactor-remove-deprecations branch from 66a5504 to c5516bc Compare July 4, 2025 17:50
@Shinigami92 Shinigami92 force-pushed the refactor-remove-deprecations branch from 51837ac to dfc58e1 Compare July 4, 2025 18:01
Copy link
Member

@xDivisionByZerox xDivisionByZerox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just one more 🙂

Or, not...

@Shinigami92 Shinigami92 added this pull request to the merge queue Jul 4, 2025
Merged via the queue into next with commit 623d274 Jul 4, 2025
23 checks passed
@Shinigami92 Shinigami92 deleted the refactor-remove-deprecations branch July 4, 2025 18:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

breaking change Cannot be merged when next version is not a major release c: refactor PR that affects the runtime behavior, but doesn't add new features or fixes bugs

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants