Skip to content

Conversation

@ST-DDT
Copy link
Member

@ST-DDT ST-DDT commented Sep 1, 2024

I tried enabling @typescript-eslint/no-unnecessary-condition but in the end only this changes made the code better.

@ST-DDT ST-DDT added c: chore PR that doesn't affect the runtime behavior p: 1-normal Nothing urgent labels Sep 1, 2024
@ST-DDT ST-DDT added this to the vAnytime milestone Sep 1, 2024
@ST-DDT ST-DDT requested review from a team September 1, 2024 18:59
@ST-DDT ST-DDT self-assigned this Sep 1, 2024
@netlify
Copy link

netlify bot commented Sep 1, 2024

Deploy Preview for fakerjs ready!

Name Link
🔨 Latest commit 0b75bc1
🔍 Latest deploy log https://app.netlify.com/sites/fakerjs/deploys/66df7d694c8658000836783c
😎 Deploy Preview https://deploy-preview-3081.fakerjs.dev
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@codecov
Copy link

codecov bot commented Sep 1, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.97%. Comparing base (acb8b52) to head (0b75bc1).
Report is 1 commits behind head on next.

Additional details and impacted files
@@           Coverage Diff            @@
##             next    #3081    +/-   ##
========================================
  Coverage   99.96%   99.97%            
========================================
  Files        2776     2776            
  Lines      226260   226260            
  Branches      590      943   +353     
========================================
+ Hits       226178   226195    +17     
+ Misses         82       65    -17     

see 2 files with indirect coverage changes

@ST-DDT ST-DDT enabled auto-merge (squash) September 9, 2024 22:55
@ST-DDT ST-DDT merged commit 18ab2c7 into next Sep 9, 2024
@ST-DDT ST-DDT deleted the refactor/test/nullish-access branch September 9, 2024 23:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

c: chore PR that doesn't affect the runtime behavior p: 1-normal Nothing urgent

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants