Skip to content

Conversation

@xDivisionByZerox
Copy link
Member

Description

Follow-on to #2265.

Normalize the entries in the database module definitions in all locales.

I choose this module as locale data are somewhat limited. Furthermore, none of the datasets surpass the 1k entry limit, meaning that all modifications to locale files involve sorting entries only.

@xDivisionByZerox xDivisionByZerox added p: 1-normal Nothing urgent c: refactor PR that affects the runtime behavior, but doesn't add new features or fixes bugs c: locale Permutes locale definitions m: database Something is referring to the database module labels May 3, 2024
@xDivisionByZerox xDivisionByZerox requested a review from a team May 3, 2024 17:37
@xDivisionByZerox xDivisionByZerox self-assigned this May 3, 2024
@xDivisionByZerox xDivisionByZerox requested a review from a team as a code owner May 3, 2024 17:37
@xDivisionByZerox xDivisionByZerox added this to the vAnytime milestone May 3, 2024
@netlify
Copy link

netlify bot commented May 3, 2024

Deploy Preview for fakerjs ready!

Name Link
🔨 Latest commit ed9f5ee
🔍 Latest deploy log https://app.netlify.com/sites/fakerjs/deploys/663520f8a09ac50008618d3f
😎 Deploy Preview https://deploy-preview-2873.fakerjs.dev
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@codecov
Copy link

codecov bot commented May 3, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.96%. Comparing base (425997f) to head (ed9f5ee).

Additional details and impacted files
@@           Coverage Diff           @@
##             next    #2873   +/-   ##
=======================================
  Coverage   99.95%   99.96%           
=======================================
  Files        2975     2975           
  Lines      214451   214451           
  Branches      948      949    +1     
=======================================
+ Hits       214364   214372    +8     
+ Misses         87       79    -8     
Files Coverage Δ
src/locales/base/database/collation.ts 100.00% <100.00%> (ø)
src/locales/base/database/engine.ts 100.00% <100.00%> (ø)
src/locales/base/database/type.ts 100.00% <100.00%> (ø)
src/locales/de/database/column.ts 100.00% <100.00%> (ø)
src/locales/en/database/column.ts 100.00% <100.00%> (ø)
src/locales/eo/database/column.ts 100.00% <100.00%> (ø)
src/locales/zh_CN/database/column.ts 100.00% <100.00%> (ø)

... and 1 file with indirect coverage changes

@xDivisionByZerox xDivisionByZerox requested review from a team May 4, 2024 19:35
@xDivisionByZerox xDivisionByZerox merged commit 1eea7fe into next May 5, 2024
@xDivisionByZerox xDivisionByZerox deleted the refactor/locale/normalize-database-data branch May 5, 2024 09:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

c: locale Permutes locale definitions c: refactor PR that affects the runtime behavior, but doesn't add new features or fixes bugs m: database Something is referring to the database module p: 1-normal Nothing urgent

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants