Skip to content

Conversation

@xDivisionByZerox
Copy link
Member

Description

Follow-on to #2265.

Normalize the entries in the commerce module definitions in all locales.

I choose this module as locale data are somewhat limited. Furthermore, none of the datasets surpass the 1k entry limit, meaning that all modifications to locale files involve sorting entries only.

@xDivisionByZerox xDivisionByZerox added p: 1-normal Nothing urgent c: refactor PR that affects the runtime behavior, but doesn't add new features or fixes bugs c: locale Permutes locale definitions m: commerce Something is referring to the commerce module labels May 1, 2024
@xDivisionByZerox xDivisionByZerox added this to the vAnytime milestone May 1, 2024
@xDivisionByZerox xDivisionByZerox requested a review from a team May 1, 2024 13:11
@xDivisionByZerox xDivisionByZerox requested a review from a team as a code owner May 1, 2024 13:11
@netlify
Copy link

netlify bot commented May 1, 2024

Deploy Preview for fakerjs ready!

Name Link
🔨 Latest commit 0a01125
🔍 Latest deploy log https://app.netlify.com/sites/fakerjs/deploys/66348ac2c367b900082b5581
😎 Deploy Preview https://deploy-preview-2868.fakerjs.dev
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@xDivisionByZerox xDivisionByZerox self-assigned this May 1, 2024
@codecov
Copy link

codecov bot commented May 1, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.95%. Comparing base (97ff293) to head (0a01125).

Additional details and impacted files
@@           Coverage Diff            @@
##             next    #2868    +/-   ##
========================================
  Coverage   99.95%   99.95%            
========================================
  Files        2975     2975            
  Lines      214451   214451            
  Branches      946      595   -351     
========================================
+ Hits       214351   214357     +6     
+ Misses        100       94     -6     
Files Coverage Δ
src/locales/ar/commerce/department.ts 100.00% <100.00%> (ø)
src/locales/ar/commerce/product_name.ts 100.00% <100.00%> (ø)
src/locales/az/commerce/department.ts 100.00% <100.00%> (ø)
src/locales/az/commerce/product_name.ts 100.00% <100.00%> (ø)
src/locales/el/commerce/department.ts 100.00% <100.00%> (ø)
src/locales/el/commerce/product_name.ts 100.00% <100.00%> (ø)
src/locales/en/commerce/department.ts 100.00% <100.00%> (ø)
src/locales/en/commerce/product_description.ts 100.00% <100.00%> (ø)
src/locales/en/commerce/product_name.ts 100.00% <100.00%> (ø)
src/locales/eo/commerce/product_name.ts 100.00% <100.00%> (ø)
... and 39 more

... and 1 file with indirect coverage changes

@ST-DDT ST-DDT requested a review from a team May 1, 2024 14:07
@ST-DDT ST-DDT enabled auto-merge (squash) May 3, 2024 06:56
@ST-DDT ST-DDT merged commit 425997f into next May 3, 2024
@ST-DDT ST-DDT deleted the refactor/locale/normalize-commerce-data branch May 14, 2024 17:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

c: locale Permutes locale definitions c: refactor PR that affects the runtime behavior, but doesn't add new features or fixes bugs m: commerce Something is referring to the commerce module p: 1-normal Nothing urgent

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants