Skip to content

fix: remove @internal from module parent classes #2548

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
ST-DDT merged 1 commit into from
Nov 14, 2023
Merged

fix: remove @internal from module parent classes #2548

ST-DDT merged 1 commit into from
Nov 14, 2023

Conversation

@ST-DDT
Copy link
Member

@ST-DDT ST-DDT commented Nov 14, 2023

@ST-DDT ST-DDT added c: bug Something isn't working p: 3-urgent Fix and release ASAP s: accepted Accepted feature / Confirmed bug labels Nov 14, 2023
@ST-DDT ST-DDT added this to the v8.x milestone Nov 14, 2023
@ST-DDT ST-DDT requested review from a team November 14, 2023 20:33
@ST-DDT ST-DDT self-assigned this Nov 14, 2023
@codecov
Copy link

codecov bot commented Nov 14, 2023

Codecov Report

Merging #2548 (2592977) into next (3f614f0) will decrease coverage by 0.01%.
The diff coverage is n/a.

Additional details and impacted files 
@@            Coverage Diff             @@
##             next    #2548      +/-   ##
==========================================
- Coverage   99.57%   99.57%   -0.01%     
==========================================
  Files        2806     2806              
  Lines      250064   250060       -4     
  Branches     1100     1101       +1     
==========================================
- Hits       249009   249003       -6     
- Misses       1027     1029       +2     
  Partials       28       28
Files Coverage Δ
src/internal/module-base.ts 100.00% <ø> (ø)

... and 1 file with indirect coverage changes

@ST-DDT ST-DDT enabled auto-merge (squash) November 14, 2023 20:38
@ST-DDT ST-DDT merged commit 77f54ad into next Nov 14, 2023
@ST-DDT ST-DDT deleted the hotfix/internal/base-module branch November 14, 2023 20:38
@dagistan-tuncbilek dagistan-tuncbilek mentioned this pull request Jun 14, 2024
Open
This was referenced Sep 13, 2024
Open
Open
Merged
@sindhuhack sindhuhack mentioned this pull request Sep 24, 2024
Open
@jiisuominen jiisuominen mentioned this pull request Nov 6, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ejcheng ejcheng ejcheng approved these changes

@xDivisionByZerox xDivisionByZerox xDivisionByZerox approved these changes

Assignees

@ST-DDT ST-DDT

Labels

c: bug Something isn't working p: 3-urgent Fix and release ASAP s: accepted Accepted feature / Confirmed bug

Projects

None yet

Milestone

v8.x

Development

Successfully merging this pull request may close these issues.

No exported member 'ModuleBase' with 8.3.0

4 participants

@ST-DDT @ejcheng @xDivisionByZerox