infra(unicorn): prefer-number-properties #2452
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## next #2452 +/- ##
==========================================
- Coverage 99.59% 99.58% -0.01%
==========================================
Files 2823 2823
Lines 255517 255520 +3
Branches 1104 1101 -3
==========================================
- Hits 254479 254459 -20
- Misses 1010 1033 +23
Partials 28 28
|
matthewmayer
approved these changes
Oct 9, 2023
xDivisionByZerox
previously approved these changes
Oct 9, 2023
Member
xDivisionByZerox
left a comment
xDivisionByZerox
left a comment
There was a problem hiding this comment.
- Number.isNaN() over isNaN() (they have slightly different behavior)
Wow, I didn't even knew that global isNaN() coerces inputs which do not match the 'number' type . Interesting rule!
matthewmayer
previously approved these changes
Oct 9, 2023
ejcheng
previously approved these changes
Oct 9, 2023
ST-DDT
dismissed stale reviews from ejcheng, matthewmayer, and xDivisionByZerox
via
e77b658
ST-DDT
requested review from
a team,
ejcheng,
matthewmayer and
xDivisionByZerox
xDivisionByZerox
approved these changes
Oct 16, 2023
ejcheng
approved these changes
Oct 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ref: #2439
Enables the
unicorn/prefer-number-propertieslint rule.