Fix try_recv (And add a bunch of loom based tests) #23
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
faern
commented
Aug 30, 2022
|
|
||
| #[cfg(feature = "async")] | ||
| #[test] | ||
| fn poll_then_try_recv_while_sending() { |
Owner
Author
There was a problem hiding this comment.
This is the test catching the actual bug. The rest was just added for extra caution.
Contributor
|
Yeah good catch there. To be honest I wouldn't worry too much about these degenerate cases since they're already stemming from a pretty substantial misuse of the library, and because as you mentioned these will be fixed by the end of next month. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Just after publishing 0.1.4 I realized that the
try_recvmethod did not properly handle being in theUNPARKINGstate. I wrote a loom based test proving this was the case, then I fixed the issue. I added a bunch of more loom tests while at it. Verifying that a lot of other poll interactions act sanely.Ping @Cassy343. What do you think? There are too many combinations on how one can call this library right now. To be fully correct we should also have tests trying to call
recv,recv_timeoutetc after polling also. But that's going to explode in number of tests. This will be mitigated with0.2where these call combinations are no longer possible.