Accelerate model loading on GPU by 1.24x #251
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR: Accelerate model loading by 1.24x
Summary
This PR optimizes the model loading process, resulting in a ~1.24x speedup on CUDA-enabled devices. The change is backward compatible.
Previously the model's weights were first loaded into CPU RAM and then copied in a large batch to the GPU via
model.to(device).Now, an empty model "scaffold" is created directly in GPU VRAM. PyTorch reads the weights from disk and loads them directly into GPU VRAM.
You can access the benchmarking script and results in vggt_benchmark_loading.zip.
Thank you for the great work.