This repository was archived by the owner on Jun 20, 2025. It is now read-only.
T138861426: [Bootcamp][PCF][BE] Migrate the DotproductGame to use the new API that accepts metric collector. #1967
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
CLA Signed
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D41640581 |
slaxman1978
added a commit
to slaxman1978/fbpcs
that referenced
this pull request
Dec 1, 2022
… new API that accepts metric collector. (facebookresearch#1967) Summary: Pull Request resolved: facebookresearch#1967 X-link: facebookresearch/fbpcf#453 As titled. Differential Revision: D41640581 fbshipit-source-id: af1f4e90d5d8e088c876995788ad403bb8282e41
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D41640581 |
slaxman1978
force-pushed
the
export-D41640581
branch
from
daebd28 to
296aede
Compare
slaxman1978
added a commit
to slaxman1978/fbpcf
that referenced
this pull request
Dec 1, 2022
… new API that accepts metric collector. (#1967) Summary: X-link: facebookresearch/fbpcs#1967 Pull Request resolved: facebookresearch#453 As titled. Differential Revision: D41640581 fbshipit-source-id: 9654befbab598cb7d7d704c9e7bc18f0e2229a93
slaxman1978
added a commit
to slaxman1978/fbpcs
that referenced
this pull request
Dec 1, 2022
… new API that accepts metric collector. (facebookresearch#1967) Summary: Pull Request resolved: facebookresearch#1967 X-link: facebookresearch/fbpcf#453 As titled. Differential Revision: D41640581 fbshipit-source-id: 1f0e96301db5057c07874f3844a1212075a1378d
slaxman1978
force-pushed
the
export-D41640581
branch
from
296aede to
cbb08ac
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D41640581 |
slaxman1978
added a commit
to slaxman1978/fbpcs
that referenced
this pull request
Dec 1, 2022
… new API that accepts metric collector. (facebookresearch#1967) Summary: Pull Request resolved: facebookresearch#1967 X-link: facebookresearch/fbpcf#453 As titled. Differential Revision: D41640581 fbshipit-source-id: cffd6f4df6aebc681e8f52774db2a4934b2f620c
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D41640581 |
slaxman1978
force-pushed
the
export-D41640581
branch
from
cbb08ac to
feb8297
Compare
slaxman1978
added a commit
to slaxman1978/fbpcs
that referenced
this pull request
Dec 1, 2022
… new API that accepts metric collector. (facebookresearch#1967) Summary: Pull Request resolved: facebookresearch#1967 X-link: facebookresearch/fbpcf#453 As titled. Differential Revision: D41640581 fbshipit-source-id: a4c0fbfc3b3dec6ca545c096c81a0a93b1670d01
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D41640581 |
slaxman1978
force-pushed
the
export-D41640581
branch
from
feb8297 to
dfa3865
Compare
…e the new API that accepts metric collector. (facebookresearch#1967) Summary: Pull Request resolved: facebookresearch#1967 X-link: facebookresearch/fbpcf#453 As titled. Differential Revision: D41640581 fbshipit-source-id: d44b8811ed7be8bdf58c730659dffee1ee537732
slaxman1978
force-pushed
the
export-D41640581
branch
from
dfa3865 to
0b1d36f
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D41640581 |
Contributor
|
This pull request has been merged in cfd622c. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary: As titled.
Differential Revision: D41640581