Skip to content

Support cosine distance for training vectors #4227

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
junjieqi wants to merge 1 commit into from
Closed

Support cosine distance for training vectors #4227

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions benchs/bench_fw/descriptors.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -106,6 +106,8 @@ class DatasetDescriptor:
# desc_name
desc_name: Optional[str] = None

normalize_L2: bool = False

def __hash__(self):
return hash(self.get_filename())

Expand Down
2 changes: 2 additions & 0 deletions benchs/bench_fw/index.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1138,6 +1138,8 @@ def assemble(self, dry_run):
return None, None, ""
logger.info(f"assemble, train {self.factory}")
xt = self.io.get_dataset(self.training_vectors)
if self.training_vectors.normalize_L2:
faiss.normalize_L2(xt)
_, t, _ = timer("train", lambda: codec.train(xt), once=True)
t_aggregate += t

Expand Down
Loading